Reverse the order of clock mod options. #16

Merged
awonak merged 5 commits from reverse-clock-mod-index into main 2025-07-22 00:00:49 +00:00
2 changed files with 13 additions and 16 deletions
Showing only changes of commit 5b1bc3d8bf - Show all commits

View File

@ -168,6 +168,21 @@ void HandleExtClockTick() {
// //
void HandlePlayPressed() { void HandlePlayPressed() {
// Check if SHIFT is pressed to mute all/current channel.
if (gravity.shift_button.On()) {
if (app.selected_channel == 0) {
// Mute all channels
for (int i = 0; i < Gravity::OUTPUT_COUNT; i++) {
app.channel[i].toggleMute();
}
} else {
// Mute selected channel
auto& ch = GetSelectedChannel();
ch.toggleMute();
}
return;
}
gravity.clock.IsPaused() gravity.clock.IsPaused()
? gravity.clock.Start() ? gravity.clock.Start()
: gravity.clock.Stop(); : gravity.clock.Stop();
@ -181,8 +196,8 @@ void HandleEncoderPressed() {
if (app.selected_channel == 0) { // main page if (app.selected_channel == 0) { // main page
// TODO: rewrite as switch // TODO: rewrite as switch
if (app.selected_param == PARAM_MAIN_ENCODER_DIR) { if (app.selected_param == PARAM_MAIN_ENCODER_DIR) {
bool reversed = app.selected_sub_param == 1; app.encoder_reversed = app.selected_sub_param == 1;
gravity.encoder.SetReverseDirection(reversed); gravity.encoder.SetReverseDirection(app.encoder_reversed);
} }
if (app.selected_param == PARAM_MAIN_SAVE_DATA) { if (app.selected_param == PARAM_MAIN_SAVE_DATA) {
if (app.selected_sub_param < MAX_SAVE_SLOTS) { if (app.selected_sub_param < MAX_SAVE_SLOTS) {
@ -203,6 +218,12 @@ void HandleEncoderPressed() {
InitGravity(app); InitGravity(app);
} }
} }
if (app.selected_param == PARAM_MAIN_FACTORY_RESET) {
if (app.selected_sub_param == 0) { // Reset
stateManager.factoryReset();
InitGravity(app);
}
}
} }
// Only mark dirty and reset selected_sub_param when leaving editing mode. // Only mark dirty and reset selected_sub_param when leaving editing mode.
stateManager.markDirty(); stateManager.markDirty();
@ -277,6 +298,9 @@ void editMainParameter(int val) {
case PARAM_MAIN_RESET_STATE: case PARAM_MAIN_RESET_STATE:
updateSelection(app.selected_sub_param, val, 2); updateSelection(app.selected_sub_param, val, 2);
break; break;
case PARAM_MAIN_FACTORY_RESET:
updateSelection(app.selected_sub_param, val, 2);
break;
} }
} }

View File

@ -38,28 +38,4 @@ static Channel& GetSelectedChannel() {
return app.channel[app.selected_channel - 1]; return app.channel[app.selected_channel - 1];
} }
enum ParamsMainPage : uint8_t {
PARAM_MAIN_TEMPO,
PARAM_MAIN_SOURCE,
PARAM_MAIN_PULSE,
PARAM_MAIN_ENCODER_DIR,
PARAM_MAIN_SAVE_DATA,
PARAM_MAIN_LOAD_DATA,
PARAM_MAIN_RESET_STATE,
PARAM_MAIN_LAST,
};
enum ParamsChannelPage : uint8_t {
PARAM_CH_MOD,
PARAM_CH_PROB,
PARAM_CH_DUTY,
PARAM_CH_OFFSET,
PARAM_CH_SWING,
PARAM_CH_EUC_STEPS,
PARAM_CH_EUC_HITS,
PARAM_CH_CV1_DEST,
PARAM_CH_CV2_DEST,
PARAM_CH_LAST,
};
#endif // APP_STATE_H #endif // APP_STATE_H

View File

@ -161,6 +161,8 @@ class Channel {
byte getSteps(bool withCvMod = false) const { return withCvMod ? pattern.GetSteps() : base_euc_steps; } byte getSteps(bool withCvMod = false) const { return withCvMod ? pattern.GetSteps() : base_euc_steps; }
byte getHits(bool withCvMod = false) const { return withCvMod ? pattern.GetHits() : base_euc_hits; } byte getHits(bool withCvMod = false) const { return withCvMod ? pattern.GetHits() : base_euc_hits; }
void toggleMute() { mute = !mute; }
/** /**
* @brief Processes a clock tick and determines if the output should be high or low. * @brief Processes a clock tick and determines if the output should be high or low.
* Note: this method is called from an ISR and must be kept as simple as possible. * Note: this method is called from an ISR and must be kept as simple as possible.
@ -168,6 +170,12 @@ class Channel {
* @param output The output object to be modified. * @param output The output object to be modified.
*/ */
void processClockTick(uint32_t tick, DigitalOutput& output) { void processClockTick(uint32_t tick, DigitalOutput& output) {
// Mute check
if (mute) {
output.Low();
return;
}
const uint16_t mod_pulses = pgm_read_word_near(&CLOCK_MOD_PULSES[cvmod_clock_mod_index]); const uint16_t mod_pulses = pgm_read_word_near(&CLOCK_MOD_PULSES[cvmod_clock_mod_index]);
// Conditionally apply swing on down beats. // Conditionally apply swing on down beats.
@ -298,6 +306,9 @@ class Channel {
// Euclidean pattern // Euclidean pattern
Pattern pattern; Pattern pattern;
// Mute channel flag
bool mute;
// Pre-calculated pulse values for ISR performance // Pre-calculated pulse values for ISR performance
uint16_t _duty_pulses; uint16_t _duty_pulses;
uint16_t _offset_pulses; uint16_t _offset_pulses;

View File

@ -96,6 +96,33 @@ constexpr uint8_t CHANNEL_BOXES_Y = 50;
constexpr uint8_t CHANNEL_BOX_WIDTH = 18; constexpr uint8_t CHANNEL_BOX_WIDTH = 18;
constexpr uint8_t CHANNEL_BOX_HEIGHT = 14; constexpr uint8_t CHANNEL_BOX_HEIGHT = 14;
// Menu items for editing global parameters.
enum ParamsMainPage : uint8_t {
PARAM_MAIN_TEMPO,
PARAM_MAIN_SOURCE,
PARAM_MAIN_PULSE,
PARAM_MAIN_ENCODER_DIR,
PARAM_MAIN_SAVE_DATA,
PARAM_MAIN_LOAD_DATA,
PARAM_MAIN_RESET_STATE,
PARAM_MAIN_FACTORY_RESET,
PARAM_MAIN_LAST,
};
// Menu items for editing channel parameters.
enum ParamsChannelPage : uint8_t {
PARAM_CH_MOD,
PARAM_CH_PROB,
PARAM_CH_DUTY,
PARAM_CH_OFFSET,
PARAM_CH_SWING,
PARAM_CH_EUC_STEPS,
PARAM_CH_EUC_HITS,
PARAM_CH_CV1_DEST,
PARAM_CH_CV2_DEST,
PARAM_CH_LAST,
};
// Helper function to draw centered text // Helper function to draw centered text
void drawCenteredText(const char* text, int y, const uint8_t* font) { void drawCenteredText(const char* text, int y, const uint8_t* font) {
gravity.display.setFont(font); gravity.display.setFont(font);
@ -278,13 +305,23 @@ void DisplayMainPage() {
mainText = F("x"); mainText = F("x");
subText = F("BACK TO MAIN"); subText = F("BACK TO MAIN");
} }
break;
case PARAM_MAIN_FACTORY_RESET:
if (app.selected_sub_param == 0) {
mainText = F("DEL");
subText = F("FACTORY RESET");
} else {
mainText = F("x");
subText = F("BACK TO MAIN");
}
break;
} }
drawCenteredText(mainText.c_str(), MAIN_TEXT_Y, LARGE_FONT); drawCenteredText(mainText.c_str(), MAIN_TEXT_Y, LARGE_FONT);
drawCenteredText(subText.c_str(), SUB_TEXT_Y, TEXT_FONT); drawCenteredText(subText.c_str(), SUB_TEXT_Y, TEXT_FONT);
// Draw Main Page menu items // Draw Main Page menu items
String menu_items[PARAM_MAIN_LAST] = {F("TEMPO"), F("SOURCE"), F("PULSE OUT"), F("ENCODER DIR"), F("SAVE"), F("LOAD"), F("RESET")}; String menu_items[PARAM_MAIN_LAST] = {F("TEMPO"), F("SOURCE"), F("PULSE OUT"), F("ENCODER DIR"), F("SAVE"), F("LOAD"), F("RESET"), F("ERASE")};
drawMenuItems(menu_items, PARAM_MAIN_LAST); drawMenuItems(menu_items, PARAM_MAIN_LAST);
} }

View File

@ -16,6 +16,7 @@
#include "app_state.h" #include "app_state.h"
// Calculate the starting address for EepromData, leaving space for metadata. // Calculate the starting address for EepromData, leaving space for metadata.
static const int METADATA_START_ADDR = 0;
static const int EEPROM_DATA_START_ADDR = sizeof(StateManager::Metadata); static const int EEPROM_DATA_START_ADDR = sizeof(StateManager::Metadata);
StateManager::StateManager() : _isDirty(false), _lastChangeTime(0) {} StateManager::StateManager() : _isDirty(false), _lastChangeTime(0) {}
@ -24,11 +25,14 @@ bool StateManager::initialize(AppState& app) {
if (_isDataValid()) { if (_isDataValid()) {
// Load data from the transient slot. // Load data from the transient slot.
return loadData(app, MAX_SAVE_SLOTS); return loadData(app, MAX_SAVE_SLOTS);
} else { }
// EEPROM does not contain save data for this firmware & version. // EEPROM does not contain save data for this firmware & version.
else {
// Erase EEPROM and initialize state. Save default pattern to all save slots.
factoryReset();
// Initialize eeprom and save default patter to all save slots. // Initialize eeprom and save default patter to all save slots.
_saveMetadata(app);
reset(app); reset(app);
_saveMetadata();
// MAX_SAVE_SLOTS slot is reserved for transient state. // MAX_SAVE_SLOTS slot is reserved for transient state.
for (int i = 0; i <= MAX_SAVE_SLOTS; i++) { for (int i = 0; i <= MAX_SAVE_SLOTS; i++) {
app.selected_save_slot = i; app.selected_save_slot = i;
@ -42,10 +46,12 @@ bool StateManager::loadData(AppState& app, byte slot_index) {
if (slot_index >= MAX_SAVE_SLOTS) return false; if (slot_index >= MAX_SAVE_SLOTS) return false;
_loadState(app, slot_index); _loadState(app, slot_index);
_loadMetadata(app);
return true; return true;
} }
// Save app state to user specified save slot.
void StateManager::saveData(const AppState& app) { void StateManager::saveData(const AppState& app) {
if (app.selected_save_slot >= MAX_SAVE_SLOTS) return; if (app.selected_save_slot >= MAX_SAVE_SLOTS) return;
@ -53,17 +59,18 @@ void StateManager::saveData(const AppState& app) {
_isDirty = false; _isDirty = false;
} }
// Save transient state if it has changed and enough time has passed since last save.
void StateManager::update(const AppState& app) { void StateManager::update(const AppState& app) {
if (_isDirty && (millis() - _lastChangeTime > SAVE_DELAY_MS)) { if (_isDirty && (millis() - _lastChangeTime > SAVE_DELAY_MS)) {
// MAX_SAVE_SLOTS slot is reserved for transient state. // MAX_SAVE_SLOTS slot is reserved for transient state.
_saveState(app, MAX_SAVE_SLOTS); _saveState(app, MAX_SAVE_SLOTS);
_saveMetadata(app);
_isDirty = false; _isDirty = false;
} }
} }
void StateManager::reset(AppState& app) { void StateManager::reset(AppState& app) {
app.tempo = Clock::DEFAULT_TEMPO; app.tempo = Clock::DEFAULT_TEMPO;
app.encoder_reversed = false;
app.selected_param = 0; app.selected_param = 0;
app.selected_channel = 0; app.selected_channel = 0;
app.selected_source = Clock::SOURCE_INTERNAL; app.selected_source = Clock::SOURCE_INTERNAL;
@ -74,6 +81,9 @@ void StateManager::reset(AppState& app) {
app.channel[i].Init(); app.channel[i].Init();
} }
// Load global settings from Metadata
_loadMetadata(app);
_isDirty = false; _isDirty = false;
} }
@ -82,9 +92,18 @@ void StateManager::markDirty() {
_lastChangeTime = millis(); _lastChangeTime = millis();
} }
// Erases all data in the EEPROM by writing 0 to every address.
void StateManager::factoryReset() {
noInterrupts();
for (unsigned int i = 0; i < EEPROM.length(); i++) {
EEPROM.write(i, 0);
}
interrupts();
}
bool StateManager::_isDataValid() { bool StateManager::_isDataValid() {
Metadata load_meta; Metadata load_meta;
EEPROM.get(0, load_meta); EEPROM.get(METADATA_START_ADDR, load_meta);
bool name_match = (strcmp(load_meta.sketch_name, SKETCH_NAME) == 0); bool name_match = (strcmp(load_meta.sketch_name, SKETCH_NAME) == 0);
bool version_match = (load_meta.version == SKETCH_VERSION); bool version_match = (load_meta.version == SKETCH_VERSION);
return name_match && version_match; return name_match && version_match;
@ -104,6 +123,10 @@ void StateManager::_saveState(const AppState& app, byte slot_index) {
save_data.selected_pulse = static_cast<byte>(app.selected_pulse); save_data.selected_pulse = static_cast<byte>(app.selected_pulse);
save_data.selected_save_slot = app.selected_save_slot; save_data.selected_save_slot = app.selected_save_slot;
// TODO: break this out into a separate function. Save State should be
// broken out into global / per-channel save methods. When saving via
// "update" only save state for the current channel since other channels
// will not have changed when saving user edits.
for (int i = 0; i < Gravity::OUTPUT_COUNT; i++) { for (int i = 0; i < Gravity::OUTPUT_COUNT; i++) {
const auto& ch = app.channel[i]; const auto& ch = app.channel[i];
auto& save_ch = save_data.channel_data[i]; auto& save_ch = save_data.channel_data[i];
@ -131,7 +154,6 @@ void StateManager::_loadState(AppState& app, byte slot_index) {
// Restore app state from loaded data. // Restore app state from loaded data.
app.tempo = load_data.tempo; app.tempo = load_data.tempo;
app.encoder_reversed = load_data.encoder_reversed;
app.selected_param = load_data.selected_param; app.selected_param = load_data.selected_param;
app.selected_channel = load_data.selected_channel; app.selected_channel = load_data.selected_channel;
app.selected_source = static_cast<Clock::Source>(load_data.selected_source); app.selected_source = static_cast<Clock::Source>(load_data.selected_source);
@ -155,11 +177,23 @@ void StateManager::_loadState(AppState& app, byte slot_index) {
interrupts(); interrupts();
} }
void StateManager::_saveMetadata() { void StateManager::_saveMetadata(const AppState& app) {
noInterrupts(); noInterrupts();
Metadata current_meta; Metadata current_meta;
strcpy(current_meta.sketch_name, SKETCH_NAME); strcpy(current_meta.sketch_name, SKETCH_NAME);
current_meta.version = SKETCH_VERSION; current_meta.version = SKETCH_VERSION;
EEPROM.put(0, current_meta);
// Global user settings
current_meta.encoder_reversed = app.encoder_reversed;
EEPROM.put(METADATA_START_ADDR, current_meta);
interrupts();
}
void StateManager::_loadMetadata(AppState& app) {
noInterrupts();
Metadata metadata;
EEPROM.get(METADATA_START_ADDR, metadata);
app.encoder_reversed = metadata.encoder_reversed;
interrupts(); interrupts();
} }

View File

@ -19,8 +19,8 @@
struct AppState; struct AppState;
// Define the constants for the current firmware. // Define the constants for the current firmware.
const char SKETCH_NAME[] = "Gravity"; const char SKETCH_NAME[] = "AltGravity";
const byte SKETCH_VERSION = 7; const byte SKETCH_VERSION = 1;
// Number of available save slots. // Number of available save slots.
const byte MAX_SAVE_SLOTS = 10; const byte MAX_SAVE_SLOTS = 10;
@ -52,11 +52,15 @@ class StateManager {
void update(const AppState& app); void update(const AppState& app);
// Indicate that state has changed and we should save. // Indicate that state has changed and we should save.
void markDirty(); void markDirty();
// Erase all data stored in the EEPROM.
void factoryReset();
// This struct holds the data that identifies the firmware version. // This struct holds the data that identifies the firmware version.
struct Metadata { struct Metadata {
byte version; byte version;
char sketch_name[16]; char sketch_name[16];
// Additional global/hardware settings
bool encoder_reversed;
}; };
struct ChannelState { struct ChannelState {
byte base_clock_mod_index; byte base_clock_mod_index;
@ -83,7 +87,8 @@ class StateManager {
private: private:
bool _isDataValid(); bool _isDataValid();
void _saveMetadata(); void _saveMetadata(const AppState& app);
void _loadMetadata(AppState& app);
void _saveState(const AppState& app, byte slot_index); void _saveState(const AppState& app, byte slot_index);
void _loadState(AppState& app, byte slot_index); void _loadState(AppState& app, byte slot_index);