awonak/libGravity
1
1
Fork 0
Code Issues Pull Requests Packages Releases 2 Activity

Fix Save/Load State #28

Merged
awonak merged 6 commits from fix-save-state into main 2025-08-17 17:18:57 +00:00
Conversation 0 Commits 6 Files Changed 4 +33 -19
awonak commented 2025-08-16 17:13:29 +00:00
Owner
Copy Link

Also improve live clock performance when loading pattern data. If the clock is playing, only load pattern and tempo, do not load global settings which impact performance.

Refactor the save / load state use of disabling interrupts by wrapping all private methods from inside the public method. This ensures we will not have a race condition if an interrupt is called in between the private method calls.

Also improve live clock performance when loading pattern data. If the clock is playing, only load pattern and tempo, do not load global settings which impact performance. Refactor the save / load state use of disabling interrupts by wrapping all private methods from inside the public method. This ensures we will not have a race condition if an interrupt is called in between the private method calls.
awonak added 3 commits 2025-08-16 17:13:30 +00:00
Fix bug in metadata save/load state. 84cafe2387 
The sketch_name char array was to short, causing a buffer overflow.
Add missing metadata field in _loadMetadata 64f467d6ac
improve the usage of disabling interrupts to avoid a potential race condition with isr being called between private method execution. 87dacd869b
awonak added 1 commit 2025-08-16 17:47:14 +00:00
improve docstring comments 330f5e6ceb
awonak added 1 commit 2025-08-16 17:58:49 +00:00
make version consistent 909d589609
awonak added 1 commit 2025-08-16 18:00:38 +00:00
one more b60dcc0e68
awonak merged commit ed625e75fc into main 2025-08-17 17:18:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Oleksiy awonak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: awonak/libGravity#28
No description provided.
Delete Branch "fix-save-state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?