awonak/libGravity
1
1
Fork 0
Code Issues Pull Requests Packages Releases 4 Activity

fix: add hysteresis to comparator gate logic to prevent noise bouncing.

Browse Source
This commit is contained in:
Adam Wonak
2026-03-09 18:56:00 -07:00
parent 3f31780deb
commit dc1a6ff5c3
1 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
firmware/Comparator/Comparator.ino
View File

@ -320,11 +320,33 @@ void loop() {
if (current_mode == MODE_COMPARATOR) { if (current_mode == MODE_COMPARATOR) {
int c1_lower = comp1_shift - (comp1_size / 2); int c1_lower = comp1_shift - (comp1_size / 2);
int c1_upper = comp1_shift + (comp1_size / 2); int c1_upper = comp1_shift + (comp1_size / 2);
bool gate1 = (cv1_val >= c1_lower && cv1_val <= c1_upper);
int c2_lower = comp2_shift - (comp2_size / 2); int c2_lower = comp2_shift - (comp2_size / 2);
int c2_upper = comp2_shift + (comp2_size / 2); int c2_upper = comp2_shift + (comp2_size / 2);
bool gate2 = (cv2_val >= c2_lower && cv2_val <= c2_upper);
const int HYSTERESIS = 4; // Margin to prevent noise bouncing at threshold
bool gate1 = prev_gate1;
if (gate1) {
if (cv1_val < c1_lower - HYSTERESIS || cv1_val > c1_upper + HYSTERESIS) {
gate1 = false;
}
} else {
if (cv1_val >= c1_lower + HYSTERESIS && cv1_val <= c1_upper - HYSTERESIS) {
gate1 = true;
}
}
bool gate2 = prev_gate2;
if (gate2) {
if (cv2_val < c2_lower - HYSTERESIS || cv2_val > c2_upper + HYSTERESIS) {
gate2 = false;
}
} else {
if (cv2_val >= c2_lower + HYSTERESIS && cv2_val <= c2_upper - HYSTERESIS) {
gate2 = true;
}
}
bool logic_and = gate1 && gate2; bool logic_and = gate1 && gate2;
bool logic_or = gate1 || gate2; bool logic_or = gate1 || gate2;